Swapping bundle publish to OCI#151
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the legacy S3-based bundle publisher and packager with an OCI registry workflow using ORAS, updates the CLI to use the Massdriver SDK and ORAS targets, and adds test data and tests for the new PackageBundle behavior.
- Introduces
PublishBundleandPackageBundlemethods underpkg/commands/publishleveraging ORAS and go-gitignore - Updates
cmd/bundle.goandpkg/commands/publish/main.goto wire in the new SDK client and ORAS-based flow - Adds
testdata/simplefixtures and apackage_test.goto verify manifest layers and media types
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/commands/publish/publisher.go & packager.go | Removed legacy S3-based publisher and packager code |
| pkg/commands/publish/publish.go | Added ORAS-based Publisher.PublishBundle implementation |
| pkg/commands/publish/package.go | Added Publisher.PackageBundle using filepath.Walk & go-gitignore |
| pkg/commands/publish/mime.go | Added MIME type mapping; defaults to "nil" |
| pkg/commands/publish/package_test.go | New tests for PackageBundle verifying layer annotations & types |
| cmd/bundle.go | Renamed CLI flag to bundle-directory; integrated Massdriver SDK |
| pkg/commands/publish/main.go | Updated Run to use SDK client, memory store, and ORAS calls |
| pkg/commands/publish/testdata/simple/* | Sample bundle files for tests |
| go.mod | Upgraded Go version and bumped dependencies for ORAS usage |
| .github/workflows/lint.yaml | Bumped Go version and updated golangci-lint action |
Comments suppressed due to low confidence (2)
pkg/commands/publish/main.go:319
- [nitpick] The tag is hard-coded to "latest" with no CLI override; consider adding a flag or parameter so users can specify a custom OCI tag.
tag := "latest"
.github/workflows/lint.yaml:25
- [nitpick] The
versionhere refers to the golangci-lint binary, not the action release; verify the intended lint version and use a matching semantic tag (e.g.,v1.xorlatest).
version: v2.1
| if mimeType, exists := mimeTypesFromExt[ext]; exists { | ||
| return mimeType | ||
| } | ||
| return "nil" |
There was a problem hiding this comment.
Returning "nil" as the default MIME type yields an invalid media type; consider using a sensible fallback such as "application/octet-stream" or "text/plain" instead.
Suggested change
| return "nil" | |
| return "application/octet-stream" |
Comment on lines
+65
to
+66
| if mimeType, exists := mimeTypesFromExt[ext]; exists { | ||
| return mimeType |
There was a problem hiding this comment.
Special multi-part extensions like ".tar.gz" won't match here because filepath.Ext returns only ".gz"; you may need to detect and handle compound extensions before the standard lookup.
Suggested change
| if mimeType, exists := mimeTypesFromExt[ext]; exists { | |
| return mimeType | |
| // Split the extension into parts for compound extensions | |
| parts := strings.Split(ext, ".") | |
| for i := len(parts) - 1; i >= 0; i-- { | |
| compoundExt := "." + strings.Join(parts[i:], ".") | |
| if mimeType, exists := mimeTypesFromExt[compoundExt]; exists { | |
| return mimeType | |
| } |
coryodaniel
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the
mass bundle publishto push to an OCI registry.